Skip to content

Commit

Permalink
scripts/checkCommits1by1: improve FIXME
Browse files Browse the repository at this point in the history
One important detail was missing.
  • Loading branch information
knocte committed Jan 29, 2024
1 parent b73ce40 commit 66e239a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion scripts/checkCommits1by1.fsx
Original file line number Diff line number Diff line change
Expand Up @@ -1287,7 +1287,8 @@ for (commitHash, _commitMsg) in prCommits do
// "no ci" string, causing PR's CI not to trigger. Solution: move the GHA
// 'if' attrib (`if: github.event_name == 'pull_request'`) from CI.yml to
// this F# script, and in case it's not PR, check branch of current commit
// and if it's the last commit of the branch and has "no ci", fail!!
// and if branch name is different than master/main, and last commit of it
// has "no ci", fail!!
let ShouldHaveCiStatus(commitMsg: string) =
// NOTE: surprisingly enough, this needs to be case-sensitive, which means
// that if commit has "[no CI]", GitHubActions will still spawn a job
Expand Down

0 comments on commit 66e239a

Please sign in to comment.