Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to specify additionalBottomSpace for keyboardManager #1821

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

Almaz5200
Copy link
Contributor

What does this implement/fix? Explain your changes.

Creates an open method that allows to specify withAdditionalBottomSpace argument for InputBarAccessoryView's bind method. This is necessary when MessageView does not occupy full screen and there is something on the bottom (in our case banner view)

Does this close any currently open issues?

I couldn't find any

Where has this been tested?

Devices/Simulators: iPhone 15 Pro, iPhone 15 Pro simulator

iOS Version: 17

Swift Version: 5.9

MessageKit Version: main branch

Copy link

@fukemy fukemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good

@Kaspik Kaspik merged commit 43f8ec3 into MessageKit:main Feb 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants