Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrimitiveObjectResolver lost the ability to deserialize strings #1574

Closed
AArnott opened this issue Mar 14, 2023 · 0 comments · Fixed by #1575
Closed

PrimitiveObjectResolver lost the ability to deserialize strings #1574

AArnott opened this issue Mar 14, 2023 · 0 comments · Fixed by #1575
Labels
bug
Milestone
v2.5

Comments

@AArnott
Copy link
Collaborator

AArnott commented Mar 14, 2023

Bug description

The PrimitiveObjectResolver is supposed to be usable to deserialize arbitrary objects to their primitive types. But in v2.5, it lost the ability to deserialize strings.

This is a regression from v2.4.59.
@AArnott AArnott added the bug label Mar 14, 2023
@AArnott AArnott added this to the v2.5 milestone Mar 14, 2023
AArnott added a commit to AArnott/MessagePack-CSharp that referenced this issue Mar 14, 2023
@AArnott
Add PrimitiveObjectResolver test for deserializing strings
0e387c5 
Repro for MessagePack-CSharp#1574
@AArnott AArnott mentioned this issue Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.5
Development

Successfully merging a pull request may close this issue.

Fix PrimitiveObjectResolver's ability to read strings AArnott/MessagePack-CSharp
1 participant
@AArnott