-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with fast delete of field content #763
Conversation
When a field content is deleted too quickly (before the sync mechanism happens), an exception is raised in the Python side. This behavior doesn't occur if you type a value in a field, wait a little bit that the sync happens, and delete it. What's happening is that the code related to the netpyne field tries to delete a key that doesn't exists yet (see the video below). The fix removes this behavior (see video below)
all tests are failing here, @SimaoBolota-MetaCell @aranega could you sync to understand the problem please? Thx |
@ddelpiano I think it's just a problem of sync with EDIT> Nope, it seems that there is some selectors that are not working anymore for the tests. I'll try to debug that. |
@ddelpiano After a small investivation, it looks like some ids in the CSS selectors for DOM elements are not found. In the first place, I thought it was because the tests where testing the EDIT> I didn't find exactly why the test are failing. They are for |
Hi @ddelpiano @aranega |
Fixed now! |
@enicolasgomez could you please review this and merge if you are ok? Thanks! |
When a field content is deleted too quickly (before the sync mechanism happens), an exception is raised in the Python side.
This behavior doesn't occur if you type a value in a field, wait a little bit that the sync happens, and delete it.
What's happening is that the code related to the netpyne field tries to delete a key that doesn't exists yet (see the video below).
issue-2023-10-18_02.31.38.mp4
The fix removes this behavior (see video below)
fix-2023-10-18_02.34.49.mp4