CDE-60 Lab name and chips counter to be linked to the dataset we are mapping #26
Conversation
lib/components/steps/Home.tsx
Outdated
| } = useCdeContext(); | ||
|
|
||
| const [numberOfMapped, setNumberOfMapped] = React.useState(0); | ||
| const suggestionsMapping = getSuggestions(); |
There was a problem hiding this comment.
question: @Aiga115 why is this done using a getter function and is the datasetMapping not done using a getter function
There was a problem hiding this comment.
I used getSuggestions function as it was mentioned in a description of a task -> https://metacell.atlassian.net/jira/software/c/projects/CDE/boards/44?selectedIssue=CDE-60
if you follow a link in a description of a task it will get you to function's reference
But is there a getter function to get dataset mapping? I don't think there is @zsinnema
There was a problem hiding this comment.
I will look into this one @Aiga115
There was a problem hiding this comment.
@zsinnema please have a look at the changes done in commit 1d6e643. Based on our conversation, I decided to split the cde context into 3 different contexts; each with a different purpose:
Data Context: Holds the application's core data;
Service Context: Encapsulates functions and operations that act upon the data;
UI Context: Manages UI-related state and interaction;
For the components that we will create, if they need the data exactly as it is stored, I believe it's fine to use the data context; However, if the component needs to perform some transformation or do some calculations based on the data stored it should use the service context.
lib/components/steps/Home.tsx
Outdated
| const suggestionsMapping = getSuggestions(); | ||
|
|
||
| const sumOfMappedAndUnmapped = Object.keys(datasetMapping).length; | ||
| const numberOfUnmapped = sumOfMappedAndUnmapped - numberOfMapped; |
| suggestions, | ||
| } = useDataContext(); | ||
|
|
||
| const datasetMappingService = useMemo(() => { |
There was a problem hiding this comment.
@afonsobspinto why do we need to wrap these functions in a context?
There was a problem hiding this comment.
It is not mandatory that we have this service wrapped in a context. It is just a way to have easy access to the data that the services work on.
I like that with the current implementation the components don't need to do useDataContext to get the data to pass for the services but I'm not opposed to change if you prefer otherwise.
Issue #CDE-60
Problem: Lab name and chips counter to be linked to the dataset we are mapping
Solution:
Use isRowMapped method to calculate number of mapped data, use total length of datasetMapping to calculate total number of mapped and unmapped data, use the difference between total number of data and number of mapped data to calculate the number of unmapped data, and use getSuggestions method to calculate total number of suggestions available.