refactor!: use better CAIP types + add generic type in definePattern
#150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
changed the title
@metamask/utils
ccharly
changed the title
ccharly
changed the title
ccharly
changed the title
definePattern
darioAnongba
approved these changes
Jan 17, 2025
danroc
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now those types have been moved to
@metamask/utils, so just re-export them to keep them in the API.Also, we are still re-defining the structs, since our
definePatternallow for better error messages.This is BREAKING for the
keyring-apisince the CAIP types used in the public API will now be more restrictive (${string}:${string}/${string}:${string}forCaipAssetTyperather than a simplestring)