Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: make scopes more restrictive #159

Merged
merged 10 commits into from
Jan 24, 2025
Merged

Conversation

ccharly
Copy link
Collaborator

@ccharly ccharly commented Jan 24, 2025

Adding a more restricted scopes field to each account type definitions (Struct).

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ccharly
Copy link
Collaborator Author

ccharly commented Jan 24, 2025

@metamaskbot publish-preview

Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "14.0.0-7ba2de1",
  "@metamask-previews/eth-hd-keyring": "9.0.1-7ba2de1",
  "@metamask-previews/eth-ledger-bridge-keyring": "8.0.3-7ba2de1",
  "@metamask-previews/eth-simple-keyring": "8.0.1-7ba2de1",
  "@metamask-previews/eth-trezor-keyring": "6.0.1-7ba2de1",
  "@metamask-previews/keyring-internal-api": "2.0.1-7ba2de1",
  "@metamask-previews/keyring-internal-snap-client": "3.0.0-7ba2de1",
  "@metamask-previews/eth-snap-keyring": "8.1.1-7ba2de1",
  "@metamask-previews/keyring-snap-client": "3.0.0-7ba2de1",
  "@metamask-previews/keyring-snap-sdk": "2.1.0-7ba2de1",
  "@metamask-previews/keyring-utils": "1.2.0-7ba2de1"
}

ccharly and others added 2 commits January 24, 2025 17:36
Co-authored-by: Daniel Rocha <68558152+danroc@users.noreply.github.com>
@ccharly ccharly marked this pull request as ready for review January 24, 2025 16:44
@ccharly ccharly requested a review from a team as a code owner January 24, 2025 16:44
@ccharly ccharly enabled auto-merge January 24, 2025 16:44
@ccharly ccharly added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 3eae7aa Jan 24, 2025
30 checks passed
@ccharly ccharly deleted the fix/make-scopes-more-restrictive branch January 24, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants