Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: enforce that scopes contains CAIP-2 chain IDs #165

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Conversation

danroc
Copy link
Contributor

@danroc danroc commented Jan 28, 2025

This PR updates the type of the scopes property in the KeyringAccount type to restrict it to CAIP-2 chain IDs.

The motivation for this change stems from CASA reserving the 0 chain reference of the eip155 namespace for EOA accounts (i.e., eip155:0:<address>), eliminating the need to support namespaces in KeyringAccount.

@danroc danroc requested a review from a team as a code owner January 28, 2025 12:49
@danroc
Copy link
Contributor Author

danroc commented Jan 28, 2025

@metamaskbot publish-previews

@danroc danroc marked this pull request as draft January 28, 2025 13:13
Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "15.0.0-9c70d70",
  "@metamask-previews/eth-hd-keyring": "9.0.1-9c70d70",
  "@metamask-previews/eth-ledger-bridge-keyring": "8.0.3-9c70d70",
  "@metamask-previews/eth-simple-keyring": "8.0.1-9c70d70",
  "@metamask-previews/eth-trezor-keyring": "6.0.1-9c70d70",
  "@metamask-previews/keyring-internal-api": "3.0.0-9c70d70",
  "@metamask-previews/keyring-internal-snap-client": "3.0.1-9c70d70",
  "@metamask-previews/eth-snap-keyring": "9.0.0-9c70d70",
  "@metamask-previews/keyring-snap-client": "3.0.1-9c70d70",
  "@metamask-previews/keyring-snap-sdk": "2.1.0-9c70d70",
  "@metamask-previews/keyring-utils": "1.3.0-9c70d70"
}

@danroc
Copy link
Contributor Author

danroc commented Jan 28, 2025

@metamaskbot publish-previews

Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "15.0.0-30e933c",
  "@metamask-previews/eth-hd-keyring": "9.0.1-30e933c",
  "@metamask-previews/eth-ledger-bridge-keyring": "8.0.3-30e933c",
  "@metamask-previews/eth-simple-keyring": "8.0.1-30e933c",
  "@metamask-previews/eth-trezor-keyring": "6.0.1-30e933c",
  "@metamask-previews/keyring-internal-api": "3.0.0-30e933c",
  "@metamask-previews/keyring-internal-snap-client": "3.0.1-30e933c",
  "@metamask-previews/eth-snap-keyring": "9.0.0-30e933c",
  "@metamask-previews/keyring-snap-client": "3.0.1-30e933c",
  "@metamask-previews/keyring-snap-sdk": "2.1.0-30e933c",
  "@metamask-previews/keyring-utils": "1.3.0-30e933c"
}

@danroc danroc marked this pull request as ready for review January 28, 2025 17:17
@danroc danroc added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 3111c56 Jan 28, 2025
30 checks passed
@danroc danroc deleted the dr/scopes branch January 28, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants