Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix report script for unpublished packages #93

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Fix report script for unpublished packages #93

merged 2 commits into from
Jul 11, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jul 11, 2024

pkdiff throws an error if the package is not published:

@ts-bridge/resolver
@ts-bridge/resolver@latest: downloading...
Error: Download failed: @ts-bridge/resolver@latest from registry: https://registry.npmjs.org/
    at /usr/local/lib/node_modules/pkdiff/src/compare.js:188:15

This makes it return with exit code 1, causing the publish to fail. As as simple workaround I've added || true, which always returns exit code 0.

@Mrtenz Mrtenz requested a review from a team as a code owner July 11, 2024 10:05
Gudahtt
Gudahtt approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz merged commit 4d330a9 into main Jul 11, 2024
12 checks passed
@Mrtenz Mrtenz deleted the mrtenz/fix-report-script branch July 11, 2024 10:52
Mrtenz added a commit that referenced this pull request Jul 11, 2024
@Mrtenz
Add changelog entry for #93
92f1bc1
Mrtenz added a commit that referenced this pull request Jul 11, 2024
@github-actions @legobeat @Mrtenz
5.2.0 (#91)
eb31ebd 
* 5.2.0

* update changelog

* Add changelog entry for #93

* Add changelog entry for #90

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mrtenz @Gudahtt