Skip to content

Commit

Permalink
NftDetectionController: providerConfig -> selectedNetworkClientId (#4307
Browse files Browse the repository at this point in the history
)

The `providerConfig` state property is being removed from
NetworkController. Currently this property is used in
NftDetectionController to get the currently selected chain, but
`selectedNetworkClientId` can be used instead. This commit makes that
transition so that we can fully drop `providerConfig`.
  • Loading branch information
mcmire authored May 23, 2024
1 parent d5e007b commit 43c3d30
Show file tree
Hide file tree
Showing 3 changed files with 324 additions and 123 deletions.
6 changes: 4 additions & 2 deletions packages/assets-controllers/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Uncategorized

- **BREAKING:** The NftController messenger must now allow the `NetworkController:getNetworkClientById` action ([#XXXX](https://github.com/MetaMask/core/pull/XXXX))
- NftControllerMessenger now makes use of `selectedNetworkClientId` when responding to changes in NetworkController state to capture the currently selected chain rather than `providerConfig` ([#XXXX](https://github.com/MetaMask/core/pull/XXXX))
- **BREAKING:** The NftController messenger must now allow the `NetworkController:getNetworkClientById` action ([#4305](https://github.com/MetaMask/core/pull/4305))
- NftControllerMessenger now makes use of `selectedNetworkClientId` when responding to changes in NetworkController state to capture the currently selected chain rather than `providerConfig` ([#4305](https://github.com/MetaMask/core/pull/4305))
- This should be functionally equivalent, but is being noted anyway.
- NftDetectionController now makes use of `selectedNetworkClientId` when responding to changes in NetworkController state to capture the currently selected chain rather than `providerConfig` ([#4307](https://github.com/MetaMask/core/pull/4307))
- This should be functionally equivalent, but is being noted anyway.

## [29.0.0]
Expand Down
Loading

0 comments on commit 43c3d30

Please sign in to comment.