Standardize repo tooling (#7)

* use yarn; update dev dependencies

* standardize repo

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

merged-packages/json-rpc-middleware-stream/.circleci/config.yml

@@ -0,0 +1,66 @@
+version: 2.1
+
+workflows:
+  build-test:
+    jobs:
+      - prep-deps
+      - test-lint:
+          requires:
+            - prep-deps
+      - test-unit:
+          requires:
+            - prep-deps
+      - all-tests-pass:
+          requires:
+            - test-lint
+            - test-unit
+
+jobs:
+  prep-deps:
+    docker:
+      - image: circleci/node:10
+    steps:
+      - checkout
+      - run:
+          name: Install deps
+          command: |
+            .circleci/scripts/deps-install.sh
+      - run:
+          name: Collect yarn install HAR logs
+          command: |
+            .circleci/scripts/collect-har-artifact.sh
+      - persist_to_workspace:
+          root: .
+          paths:
+          - node_modules
+          - build-artifacts
+
+  test-lint:
+    docker:
+      - image: circleci/node:10
+    steps:
+      - checkout
+      - attach_workspace:
+          at: .
+      - run:
+          name: Lint
+          command: yarn lint
+
+  test-unit:
+    docker:
+      - image: circleci/node:10
+    steps:
+      - checkout
+      - attach_workspace:
+          at: .
+      - run:
+          name: Unit tests
+          command: yarn test
+
+  all-tests-pass:
+    docker:
+      - image: circleci/node:10
+    steps:
+      - run:
+          name: All tests passed
+          command: echo 'Great success'

merged-packages/json-rpc-middleware-stream/.circleci/scripts/collect-har-artifact.sh

@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+
+set -x
+set -e
+set -u
+set -o pipefail
+
+mkdir -p build-artifacts/yarn-install-har
+mv ./*.har build-artifacts/yarn-install-har/

merged-packages/json-rpc-middleware-stream/.circleci/scripts/deps-install.sh

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+
+set -x
+set -e
+set -u
+set -o pipefail
+
+yarn --frozen-lockfile --ignore-scripts --har

merged-packages/json-rpc-middleware-stream/.eslintrc.js

@@ -0,0 +1,16 @@
+module.exports = {
+  parserOptions: {
+    ecmaVersion: 2018,
+  },
+  plugins: [
+    'json',
+  ],
+  extends: [
+    '@metamask/eslint-config',
+    '@metamask/eslint-config/config/nodejs',
+  ],
+  ignorePatterns: [
+    '!.eslintrc.js',
+    'node_modules/',
+  ],
+}

merged-packages/json-rpc-middleware-stream/.gitignore

@@ -1,4 +1,6 @@
 
+package-lock.json
+
 # Created by https://www.gitignore.io/api/osx,node
 
 ### Node ###

merged-packages/json-rpc-middleware-stream/.nvmrc

@@ -0,0 +1 @@
+v10

merged-packages/json-rpc-middleware-stream/README.md

@@ -1,3 +1,3 @@
 # json-rpc-middleware-stream
 
-A small toolset for streaming json rpc and matching requests and responses. Made to be used with `json-rpc-engine`.
+A small toolset for streaming JSON RPC data and matching requests and responses. Made to be used with [`json-rpc-engine`](https://npmjs.com/package/json-rpc-engine).

merged-packages/json-rpc-middleware-stream/engineStream.js

@@ -1,9 +1,11 @@
-const DuplexStream = require('readable-stream').Duplex
+const { Duplex: DuplexStream } = require('readable-stream')
 
-module.exports = createEngineStream
+module.exports = function createEngineStream ({ engine }) {
+
+  if (!engine) {
+    throw new Error('Missing engine parameter!')
+  }
 
-function createEngineStream({ engine }) {
-  if (!engine) throw new Error('Missing engine parameter!')
   const stream = new DuplexStream({ objectMode: true, read, write })
   // forward notifications
   if (engine.on) {
@@ -16,8 +18,9 @@ function createEngineStream({ engine }) {
   function read () {
     return false
   }
-  function write (req, encoding, cb) {
-    engine.handle(req, (err, res) => {
+
+  function write (req, _encoding, cb) {
+    engine.handle(req, (_err, res) => {
       this.push(res)
     })
     cb()

merged-packages/json-rpc-middleware-stream/index.js

@@ -1,9 +1,7 @@
 const SafeEventEmitter = require('safe-event-emitter')
-const DuplexStream = require('readable-stream').Duplex
+const { Duplex: DuplexStream } = require('readable-stream')
 
-module.exports = createStreamMiddleware
-
-function createStreamMiddleware() {
+module.exports = function createStreamMiddleware () {
   const idMap = {}
   const stream = new DuplexStream({
     objectMode: true,
@@ -26,7 +24,7 @@ function createStreamMiddleware() {
     return false
   }
 
-  function processMessage (res, encoding, cb) {
+  function processMessage (res, _encoding, cb) {
     let err
     try {
       const isNotification = !res.id
@@ -42,9 +40,11 @@ function createStreamMiddleware() {
     cb(err)
   }
 
-  function processResponse(res) {
+  function processResponse (res) {
     const context = idMap[res.id]
-    if (!context) throw new Error(`StreamMiddleware - Unknown response id ${res.id}`)
+    if (!context) {
+      throw new Error(`StreamMiddleware - Unknown response id ${res.id}`)
+    }
     delete idMap[res.id]
     // copy whole res onto original res
     Object.assign(context.res, res)
@@ -53,8 +53,7 @@ function createStreamMiddleware() {
     setTimeout(context.end)
   }
 
-  function processNotification(res) {
+  function processNotification (res) {
     events.emit('notification', res)
   }
-
 }