bugfix/speedup cancel transaction (#249)

* ignoredecimals * radix
MetaMask · Oct 11, 2023 · b417a84 · b417a84
1 parent a92dfa9
commit b417a84
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/transaction/TransactionController.ts b/src/transaction/TransactionController.ts
@@ -542,7 +542,7 @@ export class TransactionController extends BaseController<TransactionConfig, Tra
 		const existingGasPrice = transactionMeta.transaction.gasPrice;
 		/* istanbul ignore next */
 		const existingGasPriceDecimal = parseInt(existingGasPrice === undefined ? '0x0' : existingGasPrice, 16);
-		const gasPrice = addHexPrefix(`${parseFloat(`${existingGasPriceDecimal * CANCEL_RATE}`).toString(16)}`);
+		const gasPrice = addHexPrefix(`${parseInt(`${existingGasPriceDecimal * CANCEL_RATE}`, 10).toString(16)}`);
 
 		const ethTransaction = new Transaction({
 			from: transactionMeta.transaction.from,
@@ -581,7 +581,7 @@ export class TransactionController extends BaseController<TransactionConfig, Tra
 		const existingGasPrice = transactionMeta.transaction.gasPrice;
 		/* istanbul ignore next */
 		const existingGasPriceDecimal = parseInt(existingGasPrice === undefined ? '0x0' : existingGasPrice, 16);
-		const gasPrice = addHexPrefix(`${parseFloat(`${existingGasPriceDecimal * SPEED_UP_RATE}`).toString(16)}`);
+		const gasPrice = addHexPrefix(`${parseInt(`${existingGasPriceDecimal * SPEED_UP_RATE}`, 10).toString(16)}`);
 		const ethTransaction = new Transaction({ ...transactionMeta.transaction, gasPrice });
 		await this.sign(ethTransaction, transactionMeta.transaction.from);
 		const rawTransaction = bufferToHex(ethTransaction.serialize());

diff --git a/tests/TransactionController.test.ts b/tests/TransactionController.test.ts
@@ -775,14 +775,14 @@ describe('TransactionController', () => {
 			await controller.addTransaction({
 				from,
 				gas: '0x0',
-				gasPrice: '0x1',
+				gasPrice: '0x50fd51da',
 				to: from,
 				value: '0x0'
 			});
 			await controller.speedUpTransaction(controller.state.transactions[0].id);
 
 			expect(controller.state.transactions.length).toBe(2);
-			expect(controller.state.transactions[1].transaction.gasPrice).toBe('0x1.199999999999a');
+			expect(controller.state.transactions[1].transaction.gasPrice).toBe('0x5916a6d6');
 			resolve();
 		});
 	});