Update packages and configs for eslint and prettier
#1683
Assignees
Labels
Comments
MajorLift
added a commit
that referenced
this issue
Sep 22, 2023
…norepo - added: `eslint-plugin-promise` - removed: `eslint-plugin-node` Closes #1683
3 tasks
MajorLift
added a commit
to MetaMask/eth-json-rpc-provider
that referenced
this issue
Sep 25, 2023
…norepo - added: `eslint-plugin-promise` - removed: `eslint-plugin-node` See: MetaMask/core#1683
MajorLift
added a commit
to MetaMask/eth-json-rpc-provider
that referenced
this issue
Sep 25, 2023
- added `eslint-import-resolver-typescript` v2.5.0 as dependency See: MetaMask/core#1683
MajorLift
added a commit
that referenced
this issue
Sep 27, 2023
…norepo - added: `eslint-plugin-promise` - removed: `eslint-plugin-node` See: #1683
MajorLift
added a commit
that referenced
this issue
Sep 27, 2023
- added `eslint-import-resolver-typescript` v2.5.0 as dependency See: #1683
MajorLift
added a commit
to MetaMask/eth-json-rpc-provider
that referenced
this issue
Sep 28, 2023
…of migration (#28) ## Description - This PR aligns the ESLint and Prettier packages and configs in this repo with the core monorepo. - This is a preparation step for migrating the `eth-json-rpc-provider` package into the core monorepo. - Originally, the plan was to decrement the TypeScript version to align with the core monorepo, but following [this discussion](#27), we've opted to use TypeScript version v4.8.4, and preserve the compiler options in this package that aren't enabled in the core monorepo. ## References - See MetaMask/core#1551 - Closes MetaMask/core#1683 - Closes MetaMask/core#1682 (is superseded by this PR)
MajorLift
added a commit
that referenced
this issue
Sep 29, 2023
…of migration (#28) ## Description - This PR aligns the ESLint and Prettier packages and configs in this repo with the core monorepo. - This is a preparation step for migrating the `eth-json-rpc-provider` package into the core monorepo. - Originally, the plan was to decrement the TypeScript version to align with the core monorepo, but following [this discussion](MetaMask/eth-json-rpc-provider#27), we've opted to use TypeScript version v4.8.4, and preserve the compiler options in this package that aren't enabled in the core monorepo. ## References - See #1551 - Closes #1683 - Closes #1682 (is superseded by this PR)
MajorLift
added a commit
that referenced
this issue
Oct 11, 2023
…norepo - added: `eslint-plugin-promise` - removed: `eslint-plugin-node` See: #1683
MajorLift
added a commit
that referenced
this issue
Oct 11, 2023
- added `eslint-import-resolver-typescript` v2.5.0 as dependency See: #1683
MajorLift
added a commit
that referenced
this issue
Oct 11, 2023
…of migration (#28) ## Description - This PR aligns the ESLint and Prettier packages and configs in this repo with the core monorepo. - This is a preparation step for migrating the `eth-json-rpc-provider` package into the core monorepo. - Originally, the plan was to decrement the TypeScript version to align with the core monorepo, but following [this discussion](MetaMask/eth-json-rpc-provider#27), we've opted to use TypeScript version v4.8.4, and preserve the compiler options in this package that aren't enabled in the core monorepo. ## References - See #1551 - Closes #1683 - Closes #1682 (is superseded by this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the core monorepo is using these package versions related to
eslintandprettier:To migrate
@metamask/eth-json-rpc-providerinto the core monorepo smoothly, we should match the package versions of the core monorepo, updating the ones that differ and updating the config when needed (.prettierrc*,.eslintrc.jsetc.. see the module template for reference).The text was updated successfully, but these errors were encountered: