Create EthereumAddress interface and class #25
Labels
Comments
|
Agreed. We should use this type both internally as soon as possible and eventually externally once all consuming applications are also using TypeScript. |
rickycodes
added a commit
that referenced
this issue
Nov 23, 2022
kanthesha
pushed a commit
that referenced
this issue
Sep 19, 2023
Standardizes this repository per the module template as of Q3 2022. All changes are copied over directly from the template, except for the tests, which have been rewritten. A couple of notes: - I didn't bother rewriting the tests for JSON-RPC notifications, as that functionality will be implemented in a completely different manner in #24 has been merged. - CI has been switched from CircleCI to GitHub Actions.
MajorLift
pushed a commit
that referenced
this issue
Sep 22, 2023
…25) * deps: @metamask/utils@^5.0.1->^8.1.0 * deps: @metamask/json-rpc-engine@^7.0.0->^7.1.0 * deps: @metamask/utils@^7.1.0->^8.1.0
kanthesha
pushed a commit
that referenced
this issue
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this issue
Oct 11, 2023
Standardizes this repository per the module template as of Q3 2022. All changes are copied over directly from the template, except for the tests, which have been rewritten. A couple of notes: - I didn't bother rewriting the tests for JSON-RPC notifications, as that functionality will be implemented in a completely different manner in #24 has been merged. - CI has been switched from CircleCI to GitHub Actions.
MajorLift
pushed a commit
that referenced
this issue
Oct 11, 2023
Standardizes this repository per the module template as of Q3 2022. All changes are copied over directly from the template, except for the tests, which have been rewritten. A couple of notes: - I didn't bother rewriting the tests for JSON-RPC notifications, as that functionality will be implemented in a completely different manner in #24 has been merged. - CI has been switched from CircleCI to GitHub Actions.
MajorLift
pushed a commit
that referenced
this issue
Oct 12, 2023
Standardizes this repository per the module template as of Q3 2022. All changes are copied over directly from the template, except for the tests, which have been rewritten. A couple of notes: - I didn't bother rewriting the tests for JSON-RPC notifications, as that functionality will be implemented in a completely different manner in #24 has been merged. - CI has been switched from CircleCI to GitHub Actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
By having an interface EthereumAddress we can forget about all the type related issues (string vs hex, etc).
If we have an EthereumAddress obj also we could call toChecksumAddress inside of the constructor and have some utility function like toShortString (which could return
0x1234...1234), etc.cc: @danfinlay
The text was updated successfully, but these errors were encountered: