Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite and test KeyringController #4

Closed
bitpshr opened this issue Jul 28, 2018 · 1 comment
Closed

Rewrite and test KeyringController #4

bitpshr opened this issue Jul 28, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@bitpshr
Copy link
Contributor

bitpshr commented Jul 28, 2018 •
edited
Loading

We should update the current KeyringController implementation to be a true GABA controller instead of wrapping metamask/KeyringController internally. Note that this also involves testing the controller fully.
@bitpshr bitpshr added the enhancement New feature or request label Jul 28, 2018
@bitpshr bitpshr changed the title Port KeyringController Rewrite KeyringController Jul 30, 2018
@bitpshr bitpshr changed the title Rewrite KeyringController Rewrite and test KeyringController Jul 30, 2018
@Gudahtt
Copy link
Member

Gudahtt commented Nov 4, 2021

This is now covered by #431

@Gudahtt Gudahtt closed this as completed Nov 4, 2021
kanthesha pushed a commit that referenced this issue Sep 19, 2023
@dependabot
Bump lodash from 4.17.11 to 4.17.15 (#4)
a427552 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15.

- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.11...4.17.15)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MajorLift pushed a commit that referenced this issue Sep 22, 2023
@dependabot @Gudahtt
Bump @metamask/eslint-config-nodejs from 11.0.1 to 11.1.0 (#4)
c9c6443 
Bumps [@metamask/eslint-config-nodejs](https://github.com/MetaMask/eslint-config) from 11.0.1 to 11.1.0.
- [Release notes](https://github.com/MetaMask/eslint-config/releases)
- [Commits](MetaMask/eslint-config@v11.0.1...v11.1.0)

---
updated-dependencies:
- dependency-name: "@metamask/eslint-config-nodejs"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@dependabot @MajorLift
Bump lodash from 4.17.11 to 4.17.15 (#4)
1db93c5 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15.

- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.11...4.17.15)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@dependabot @MajorLift
Bump lodash from 4.17.11 to 4.17.15 (#4)
0692cb2 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15.

- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.11...4.17.15)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MajorLift pushed a commit that referenced this issue Oct 12, 2023
@dependabot @MajorLift
Bump lodash from 4.17.11 to 4.17.15 (#4)
753832f 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15.

- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.11...4.17.15)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bitpshr @Gudahtt