Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port NetworkController #6

Closed
bitpshr opened this issue Jul 28, 2018 · 1 comment
Closed

Port NetworkController #6

bitpshr opened this issue Jul 28, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@bitpshr
Copy link
Contributor

bitpshr commented Jul 28, 2018

We should port the existing network controller to GABA.
@bitpshr bitpshr added the enhancement New feature or request label Jul 28, 2018
@bitpshr
Copy link
Contributor Author

bitpshr commented Jul 30, 2018

Resolved by 82c4066.

@bitpshr bitpshr closed this as completed Jul 30, 2018
mcmire pushed a commit that referenced this issue Jul 17, 2023
@github-actions @rekmarks
1.0.0 (#6)
2e59ee6 
* 1.0.0

* Update CHANGELOG.md

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
kanthesha pushed a commit that referenced this issue Sep 19, 2023
@whymarrh
Add LICENSE file (#6)
bfdf6fb
MajorLift pushed a commit that referenced this issue Sep 22, 2023
@Gudahtt @adonesky1
Migrate both provider functions (#6)
315c9c0 
* Migrate both provider functions

The functions `providerFromEngine` and `providerFromMiddleware` have
been migrated from `@metamask/eth-json-rpc-middleware`.

The `SafeEventEmitterProvider` is now a class with its own separate
module, rather than a type. Hopefully this will help prevent future
type errors. The error in the `SafeEventEmitterProvider` type in
`@metamask/eth-json-rpc-middleware` has been corrected; the response in
in the callback is now optional.

Everything should be fully documented and tested.

* Export type

* Fix spelling mistake

Co-authored-by: Alex Donesky <alex.donesky@consensys.net>

* Improve test names

---------

Co-authored-by: Alex Donesky <alex.donesky@consensys.net>
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@whymarrh @MajorLift
Add LICENSE file (#6)
1a34414
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@whymarrh @MajorLift
Add LICENSE file (#6)
53b8e60
MajorLift pushed a commit that referenced this issue Oct 12, 2023
@whymarrh @MajorLift
Add LICENSE file (#6)
256a103
@mcmire mcmire mentioned this issue Mar 6, 2024
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bitpshr