-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port NetworkController #6
Labels
enhancement
New feature or request
Comments
Resolved by 82c4066. |
MajorLift
pushed a commit
that referenced
this issue
Sep 22, 2023
* Migrate both provider functions The functions `providerFromEngine` and `providerFromMiddleware` have been migrated from `@metamask/eth-json-rpc-middleware`. The `SafeEventEmitterProvider` is now a class with its own separate module, rather than a type. Hopefully this will help prevent future type errors. The error in the `SafeEventEmitterProvider` type in `@metamask/eth-json-rpc-middleware` has been corrected; the response in in the callback is now optional. Everything should be fully documented and tested. * Export type * Fix spelling mistake Co-authored-by: Alex Donesky <alex.donesky@consensys.net> * Improve test names --------- Co-authored-by: Alex Donesky <alex.donesky@consensys.net>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should port the existing network controller to GABA.
The text was updated successfully, but these errors were encountered: