Maintain activeCurrency in CurrencyRateController state #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bitpshr
reviewed
Nov 13, 2018
| @@ -85,31 +84,31 @@ export class CurrencyRateController extends BaseController<CurrencyRateConfig, C | |||
| * @param currency - ISO 4217 currency code | |||
| */ | |||
| set currency(currency: string) { | |||
| this.activeCurrency = currency; | |||
| this.update({ currentCurrency: currency }); | |||
There was a problem hiding this comment.
Since currency is now maintained as state, it doesn't need a getter at all. This whole method can go away now (and the associated tests.) Instead, downstream modules would pass in a new (or initial) currency by setting state.
|
Closing in favor of #30, which includes more related cleanup. |
3 tasks
rickycodes
added a commit
that referenced
this pull request
Nov 23, 2022
rickycodes
added a commit
that referenced
this pull request
Nov 23, 2022
* 'main' of github.com:rickycodes/controllers: 32.0.4 (#22)
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
* 3.0.0 * Update changelog Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to maintain
activeCurrencyinCurrencyRateControllerin order to persist information incurrentCurrencystate when the controller is disabled and enabled again.