-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose keyrings #23
Expose keyrings #23
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 18 18
Lines 889 889
Branches 97 97
=====================================
Hits 889 889 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One comment, then this can be merged.
In order for another project to use the logging functions provided by this library, which make use of `debug`, `@types/debug` also needs to be available. This is not a total blocker — `@types/debug` can be added manually to the project in question — but is inconvenient. This commit moves `@types/debug` to the list of `dependencies` to address this.
Required by update of `@metamask/json-rpc-engine` (#16)
* Expose keyrings * Bump version * add keyrings to state * update package-lock.json * bump version again * dont override state * obj ref * bump version * return checksummed addresses * undo version bump
* Expose keyrings * Bump version * add keyrings to state * update package-lock.json * bump version again * dont override state * obj ref * bump version * return checksummed addresses * undo version bump
GABA
KeyringController
state only exposes the encrypted vault but for account rendering purposes it's good to expose all the keyrings, their types and they public keys of each one (which is what the extension is already doing). This PR attempts to expose that newkeyrings
flag.