Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jest, @types/jest, ts-jest to v29 #3646

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

MajorLift
Copy link
Contributor

Explanation

References

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Copy link

socket-security bot commented Dec 8, 2023

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/parser@7.25.6 None 0 1.89 MB nicolo-ribaudo
npm/@babel/types@7.25.6 environment 0 2.48 MB nicolo-ribaudo
npm/@jest/console@29.7.0 None 0 19 kB simenb
npm/@jest/core@29.7.0 unsafe 0 145 kB simenb
npm/@jest/environment@29.7.0 None 0 15.9 kB simenb
npm/@jest/expect-utils@29.7.0 None 0 28.3 kB simenb
npm/@jest/expect@29.7.0 None 0 5.23 kB simenb
npm/@jest/fake-timers@29.7.0 None 0 26.3 kB simenb
npm/@jest/globals@29.7.0 None 0 5.26 kB simenb
npm/@jest/reporters@29.7.0 environment, unsafe 0 115 kB simenb
npm/@jest/schemas@29.6.3 None 0 6.07 kB simenb
npm/@jest/source-map@29.6.3 None 0 5.07 kB simenb
npm/@jest/test-result@29.7.0 None 0 15.8 kB simenb
npm/@jest/test-sequencer@29.7.0 None 0 13.6 kB simenb
npm/@jest/transform@29.7.0 None 0 52.4 kB simenb
npm/@jest/types@29.6.3 None 0 32.7 kB simenb
npm/@sinclair/typebox@0.27.8 None 0 442 kB sinclair
npm/@sinonjs/commons@3.0.1 None 0 38 kB mrgnrdrck
npm/@sinonjs/fake-timers@10.3.0 eval 0 80.1 kB fatso83
npm/@types/jest@29.5.12 None 0 78.7 kB types
npm/@types/yargs@17.0.33 None 0 60.4 kB types
npm/acorn-walk@8.3.3 None 0 52.6 kB marijn
npm/async@3.2.6 None 0 808 kB aearly
npm/babel-plugin-jest-hoist@29.6.3 None 0 14.3 kB simenb
npm/babel-preset-jest@29.6.3 None 0 2.69 kB simenb
npm/create-jest@29.7.0 None 0 15.9 kB simenb
npm/dedent@1.5.3 None 0 23.9 kB joshuakgoldberg
npm/diff-sequences@29.6.3 None 0 46 kB simenb
npm/ejs@3.1.10 eval, filesystem 0 143 kB mde
npm/emittery@0.13.1 None 0 46.5 kB sindresorhus
npm/expect@29.7.0 None 0 146 kB simenb
npm/filelist@1.0.4 filesystem 0 18.6 kB mde
npm/istanbul-lib-instrument@6.0.3 None 0 72 kB oss-bot
npm/jake@10.9.2 environment, filesystem, shell 0 175 kB mde
npm/jest-changed-files@29.7.0 environment 0 18.2 kB simenb
npm/jest-circus@29.7.0 unsafe 0 72 kB simenb
npm/jest-cli@29.7.0 None 0 33.8 kB simenb
npm/jest-config@29.7.0 None 0 114 kB simenb
npm/jest-diff@29.7.0 None 0 78.5 kB simenb
npm/jest-docblock@29.7.0 None 0 8.99 kB simenb
npm/jest-each@29.7.0 None 0 33.7 kB simenb
npm/jest-environment-jsdom@29.7.0 Transitive: eval, filesystem, network, shell, unsafe +43 6.19 MB simenb
npm/jest-environment-node@29.7.0 unsafe 0 9.37 kB simenb
npm/jest-get-type@29.6.3 None 0 3.79 kB simenb
npm/jest-haste-map@29.7.0 environment, filesystem, shell, unsafe 0 121 kB simenb
npm/jest-leak-detector@29.7.0 unsafe 0 5.59 kB simenb
npm/jest-matcher-utils@29.7.0 None 0 28.4 kB simenb
npm/jest-message-util@29.7.0 None 0 20.6 kB simenb
npm/jest-mock@29.7.0 None 0 47.5 kB simenb
npm/jest-regex-util@29.6.3 None 0 3.52 kB simenb
npm/jest-resolve-dependencies@29.7.0 None 0 8.92 kB simenb
npm/jest-resolve@29.7.0 environment, unsafe 0 65.7 kB simenb
npm/jest-runner@29.7.0 environment 0 29.6 kB simenb
npm/jest-runtime@29.7.0 unsafe 0 89.2 kB simenb
npm/jest-snapshot@29.7.0 eval 0 83.5 kB simenb
npm/jest-util@29.7.0 environment 0 41.8 kB simenb
npm/jest-validate@29.7.0 None 0 28.7 kB simenb
npm/jest-watcher@29.7.0 None 0 23.4 kB simenb
npm/jest-worker@29.7.0 environment, shell 0 90.8 kB simenb
npm/jest@29.7.0 None 0 5.01 kB simenb
npm/p-limit@3.1.0 None 0 7.75 kB sindresorhus
npm/pretty-format@29.7.0 None 0 60.7 kB simenb
npm/pure-rand@6.1.0 None 0 84 kB ndubien
npm/react-is@18.3.1 environment 0 24 kB react-bot
npm/resolve.exports@2.0.2 None 0 23.9 kB lukeed
npm/source-map-support@0.5.13 filesystem, unsafe 0 82.5 kB linusu
npm/terminal-link@3.0.0 None 0 6.31 kB sindresorhus
npm/tr46@0.0.3 None 0 268 kB sebmaster
npm/ts-jest@29.2.5 None 0 328 kB anhpnnd, kul, tsjest
npm/v8-to-istanbul@9.3.0 filesystem, unsafe 0 47.6 kB oss-bot
npm/webidl-conversions@3.0.1 None 0 12.4 kB sebmaster
npm/whatwg-url@5.0.0 None 0 49.9 kB domenic
npm/yocto-queue@0.1.0 None 0 6.03 kB sindresorhus

🚮 Removed packages: npm/@babel/parser@7.25.4), npm/@babel/types@7.25.4), npm/@jest/console@27.5.1), npm/@jest/core@27.5.1), npm/@jest/environment@27.5.1), npm/@jest/fake-timers@27.5.1), npm/@jest/globals@27.5.1), npm/@jest/reporters@27.5.1), npm/@jest/source-map@27.5.1), npm/@jest/test-result@27.5.1), npm/@jest/test-sequencer@27.5.1), npm/@jest/transform@27.5.1), npm/@jest/types@27.5.1), npm/@sinonjs/fake-timers@8.1.0), npm/@types/jest@27.5.2), npm/@types/prettier@2.7.3), npm/@types/yargs@16.0.9), npm/acorn-globals@6.0.0), npm/acorn-walk@7.2.0), npm/babel-plugin-jest-hoist@27.5.1), npm/babel-preset-jest@27.5.1), npm/browser-process-hrtime@1.0.0), npm/cssom@0.4.4), npm/data-urls@2.0.0), npm/dedent@0.7.0), npm/diff-sequences@27.5.1), npm/domexception@2.0.1), npm/emittery@0.8.1), npm/expect@27.5.1), npm/form-data@3.0.1), npm/html-encoding-sniffer@2.0.1), npm/istanbul-lib-instrument@5.2.1), npm/jest-changed-files@27.5.1), npm/jest-circus@27.5.1), npm/jest-cli@27.5.1), npm/jest-config@27.5.1), npm/jest-diff@27.5.1), npm/jest-docblock@27.5.1), npm/jest-each@27.5.1), npm/jest-environment-jsdom@27.5.1), npm/jest-environment-node@27.5.1), npm/jest-get-type@27.5.1), npm/jest-haste-map@27.5.1), npm/jest-jasmine2@27.5.1), npm/jest-leak-detector@27.5.1), npm/jest-matcher-utils@27.5.1), npm/jest-message-util@27.5.1), npm/jest-mock@27.5.1), npm/jest-regex-util@27.5.1), npm/jest-resolve-dependencies@27.5.1), npm/jest-resolve@27.5.1), npm/jest-runner@27.5.1), npm/jest-runtime@27.5.1), npm/jest-serializer@27.5.1), npm/jest-snapshot@27.5.1), npm/jest-util@27.5.1), npm/jest-validate@27.5.1), npm/jest-watcher@27.5.1), npm/jest-worker@27.5.1), npm/jest@27.5.1), npm/jsdom@16.7.0), npm/p-limit@2.3.0), npm/p-try@2.2.0), npm/parse5@6.0.1), npm/pretty-format@27.5.1), npm/react-is@17.0.2), npm/resolve.exports@1.1.1), npm/saxes@5.0.1), npm/source-map-support@0.5.21), npm/terminal-link@2.1.1), npm/throat@6.0.2), npm/tr46@2.1.0), npm/ts-jest@27.1.5), npm/v8-to-istanbul@8.1.1), npm/w3c-hr-time@1.0.2), npm/w3c-xmlserializer@2.0.0), npm/webidl-conversions@5.0.0), npm/whatwg-encoding@1.0.5), npm/whatwg-mimetype@2.3.0), npm/whatwg-url@8.7.0), npm/xml-name-validator@3.0.0)

View full report↗︎

Copy link

socket-security bot commented Dec 8, 2023

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
New author npm/tr46@3.0.0 🚫
Shell access npm/jake@10.9.2 🚫

Ignoring: npm/create-jest@29.7.0

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/tr46@3.0.0
  • @SocketSecurity ignore npm/jake@10.9.2

@@ -58,7 +58,6 @@
"@metamask/eth-json-rpc-provider": "^3.0.1",
"@metamask/json-rpc-engine": "^8.0.1",
"@metamask/utils": "^8.3.0",
"@types/jest": "^27.4.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MajorLift could we consider updating to Jest v29 first, while keeping these types? And we can remove them in a later PR.

Copy link
Contributor Author

@MajorLift MajorLift Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I restored @types/jest here: a4edbd5

@MajorLift MajorLift changed the title Bump jest, @types/jest, ts-jest to v29 and install at root level Bump jest, @types/jest, ts-jest to v29 Aug 2, 2024
@MajorLift
Copy link
Contributor Author

@SocketSecurity ignore npm/create-jest@29.7.0

@MajorLift MajorLift force-pushed the 231208-update-jest-v29 branch 2 times, most recently from fc082af to 2296059 Compare September 5, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants