-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jest
, @types/jest
, ts-jest
to v29
#3646
base: main
Are you sure you want to change the base?
Conversation
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Ignoring: Next stepsWhat is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. What is shell access?This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code. Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
c25c0b7
to
cd7052e
Compare
cd7052e
to
73ec3b0
Compare
@@ -58,7 +58,6 @@ | |||
"@metamask/eth-json-rpc-provider": "^3.0.1", | |||
"@metamask/json-rpc-engine": "^8.0.1", | |||
"@metamask/utils": "^8.3.0", | |||
"@types/jest": "^27.4.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MajorLift could we consider updating to Jest v29 first, while keeping these types? And we can remove them in a later PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! I restored @types/jest
here: a4edbd5
a7f6f25
to
a4edbd5
Compare
a4edbd5
to
55866b7
Compare
jest
, @types/jest
, ts-jest
to v29 and install at root leveljest
, @types/jest
, ts-jest
to v29
@SocketSecurity ignore npm/create-jest@29.7.0 |
530e4f8
to
9d64a0a
Compare
fc082af
to
2296059
Compare
a4a4b5a
to
abe4e31
Compare
Explanation
References
Changelog
@metamask/package-a
@metamask/package-b
Checklist