Release/138.0.0 #4170
Release/138.0.0 #4170
Conversation
BelfordZ
force-pushed
the
release/138.0.0
branch
from
8b475bd
to
54acc73
Compare
| ### Added | ||
|
|
||
| - **BREAKING**: The `QueuedRequestMiddleware` constructor now requires the `methodsWithConfirmation` param which should be a list of methods that can trigger confirmations ([#4066](https://github.com/MetaMask/core/pull/4066)) | ||
| - **BREAKING**: The `QueuedRequestController` constructor now requires the `methodsRequiringNetworkSwitch` param which should be a list of methods that need the globally selected network to switched to the dapp selected network before being processed ([#4066](https://github.com/MetaMask/core/pull/4066)) | ||
| - **BREAKING**: Clear pending confirmations (non-queued requests) after processing revokePermissions. ([#4165](https://github.com/MetaMask/controllers/pull/4165)) | ||
| - **BREAKING**: Flush the RequestQueue after processing revokePermissions. ([#4139](https://github.com/MetaMask/controllers/pull/4139)) |
There was a problem hiding this comment.
I think we should mention that QueuedRequestController requires the SelectedNetworkController:stateChange event and describe what happens
There was a problem hiding this comment.
yeah I mean theres a link to the PR with a lot of info about it. Im not sure how terse we need to be in changelogs. IMO it should be a very brief summary, becasue if you really care about the details of a given change, the best place to get the details is going to be in the PR.
There was a problem hiding this comment.
Ill add some more details tho.
There was a problem hiding this comment.
In general I think its been valuable to highlight precisely what is breaking in the PR and what changes the consumer needs to make to integrate those changes.
There was a problem hiding this comment.
lol this description i wrote is actually completely wrong. I mixed up which commits were for what. I sure am glad you got me to re-review my own stuff lol.
| ### Added | ||
|
|
||
| - **BREAKING**: The `QueuedRequestMiddleware` constructor now requires the `methodsWithConfirmation` param which should be a list of methods that can trigger confirmations ([#4066](https://github.com/MetaMask/core/pull/4066)) | ||
| - **BREAKING**: The `QueuedRequestController` constructor now requires the `methodsRequiringNetworkSwitch` param which should be a list of methods that need the globally selected network to switched to the dapp selected network before being processed ([#4066](https://github.com/MetaMask/core/pull/4066)) | ||
| - **BREAKING**: Clear pending confirmations (non-queued requests) after processing revokePermissions. ([#4165](https://github.com/MetaMask/controllers/pull/4165)) |
There was a problem hiding this comment.
should we mention new required constructor param clearPendingConfirmations and how selectedNetworkController state changes use it?
Co-authored-by: jiexi <jiexiluan@gmail.com>
Explanation
References
Changelog
@metamask/queued-request-controllerQueuedRequestMiddlewareconstructor now requires themethodsWithConfirmationparam which should be a list of methods that can trigger confirmations (#4066)QueuedRequestControllerconstructor now requires themethodsRequiringNetworkSwitchparam which should be a list of methods that need the globally selected network to switched to the dapp selected network before being processed (#4066)Checklist