Clean build artifacts locally before linting #4396
Draft
+32
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
If you run
yarn build
and then run ESLint (either in your editor or theeslint
CLI), you may see false positives — i.e., you may see lint errors show up on CI, but when you try to reproduce them locally, they mysteriously disappear. I am not 100% sure why this happens, but I believe it's because when the TypeScript-backed ESLint rules run, TypeScript will parse the type declaration files that were generated viayarn build
and use them as a reference instead of using the live version of the TypeScript files, so if the type declaration files are out of date, then the results of ESLint will also be out of date. Ensuring that all build artifacts are removed before linting makes these false positives go away.This commit adds the
lint:clean-only
package script and then adds it as a prerequisite forlint
,lint:fix
, andbuild
.References
Changelog
(There are no functional changes in this PR)
Checklist