Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet framework prototype [WIP] #4451

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Wallet framework prototype [WIP] #4451

wants to merge 4 commits into from

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 24, 2024

Explanation

This is a "wallet framework" prototype. Used for API design exploration.

References

Related to #4127

Changelog

None

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Copy link

socket-security bot commented Jun 24, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/wallet-framework@0.0.0-use.local None 0 0 B

View full report↗︎

@Gudahtt Gudahtt force-pushed the wallet-framework-mvp branch 4 times, most recently from 2acf1a5 to 4c98e69 Compare June 24, 2024 11:38
@Gudahtt
Copy link
Member Author

Gudahtt commented Jun 24, 2024

Things to test:

  • We can use all defaults (no additional controllers, middleware, or permissions)
  • We can extend by adding new controllers, middleware, or permissions
  • We can override default permissions

@Gudahtt
Copy link
Member Author

Gudahtt commented Jun 24, 2024

TODO: Consider how to refactor this class to break out some responsibilities into separate modules.

For example, we can definitely move the middleware to a separate file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant