-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repro: superstruct@2.0.0
causes errors for repos with moduleResolution
set to Node{16,Next}
#4458
Conversation
9235083
to
533251c
Compare
4e9b894
to
bff42e7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
bff42e7
to
a1285a7
Compare
…g yarn resolutions
@SocketSecurity ignore-all |
Explanation
The changes introduced in
superstruct
v2.0.0-0
don't enable us to go back to usingsuperstruct
.To demonstrate, I created a repro branch where all dependencies and nested dependencies are forced to use
superstruct
v2.0.0-0
via yarn resolutions.In the ci build run results, we still see a large number of the following error for type imports when
Node{16,Next}
is enabled:The reason for this is that our libraries are CJS and
superstruct
is ESM, and withNode{16,Next}
enabled, a CJS project can only import types from an ESM project if it exports type declarations files that are unambiguously specified as.d.cts.
Ambiguous.ts
and.d.ts
files that are interoperable between CJS/ESM are no longer supported inNode{16,Next}
.module
andmoduleResolution
ofnodenext
/node16
utils#163.References