Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(permission-controller)!: Fix various lint rule violations #4521

Merged
merged 9 commits into from
Jul 17, 2024

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Jul 12, 2024

Explanation

Fixes various @typescript-eslint violations in the permission controller. Due to the prevalence of RPC method names as object literal keys in a couple of files, an .eslintrc.js has been added to the permission controller workspace to accommodate this exception to our naming convention.

References

n/a

Changelog

@metamask/permission-controller

  • BREAKING: Rename enum property names to match PascalCase instead of camelCase
    • The affected enums are:
      • CaveatMutatorOperations
      • MethodNames

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@rekmarks rekmarks requested a review from a team as a code owner July 12, 2024 21:19
@rekmarks rekmarks changed the title refactor(permission-controller)!: Rename enum properties per naming convention refactor(permission-controller)!: Fix various lint rule violations Jul 12, 2024
@rekmarks rekmarks force-pushed the rekm/perm-ctrl-eslint-naming-convention branch from a45cc50 to 85ffa55 Compare July 12, 2024 22:13
@rekmarks rekmarks force-pushed the rekm/perm-ctrl-eslint-naming-convention branch from 4f1eaba to 29e9a41 Compare July 17, 2024 08:28
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rekmarks rekmarks merged commit 2d4a255 into main Jul 17, 2024
116 checks passed
@rekmarks rekmarks deleted the rekm/perm-ctrl-eslint-naming-convention branch July 17, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants