feat: add getNFTContractInfo
#4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
7 tasks
matthewwalsh0
previously approved these changes
Jul 17, 2024
| @@ -104,6 +104,22 @@ const GOERLI = { | |||
| ticker: NetworksTicker.goerli, | |||
| }; | |||
|
|
|||
| const CRYPTOPUNK_COLLECTION_MOCK = { | |||
There was a problem hiding this comment.
Minor, should we name these for their conceptual usage and not literal values, such as COLLECTION_MOCK_1 etc?
OGPoyraz
force-pushed
the
feat/add-getnftcontractinfo
branch
from
1509943
to
2df0c26
Compare
vinistevam
reviewed
Jul 19, 2024
| @@ -520,6 +520,12 @@ export class NftController extends BaseController< | |||
| }); | |||
| } | |||
|
|
|||
| #getNftCollectionApi(): string { | |||
| // False negative. | |||
| // eslint-disable-next-line @typescript-eslint/restrict-template-expressions | |||
There was a problem hiding this comment.
Do you know if this line is required?
There was a problem hiding this comment.
Unfortunately yes, a thread here #4506 (comment)
mcmire
reviewed
Jul 24, 2024
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
pedronfigueiredo
approved these changes
Jul 25, 2024
AugmentedMode
pushed a commit
that referenced
this pull request
Jul 30, 2024
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> This PR exposes NFT `collections` api through NFT controller. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? For example: * Fixes #12345 * Related to #67890 --> Related to: MetaMask/MetaMask-planning#2507 Extension PR using this PR's preview build: MetaMask/metamask-extension#25692 ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/assets-controllers` - **ADDED**: Add `fetchNftCollectionMetadata` to `NFTController` api ## Checklist - [X] I've updated the test suite for new or updated code as appropriate - [X] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [X] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR exposes NFT
collectionsapi through NFT controller.References
Related to: https://github.com/MetaMask/MetaMask-planning/issues/2507
Extension PR using this PR's preview build: MetaMask/metamask-extension#25692
Changelog
@metamask/assets-controllersfetchNftCollectionMetadatatoNFTControllerapiChecklist