Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: notification services controller - silently handle push notifications #4536

Merged
merged 3 commits into from
Jul 18, 2024
Merged

refactor: notification services controller - silently handle push notifications #4536

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37a3629
refactor: add error catching and silently error when push notificatio…
Prithpal-Sooriya Jul 17, 2024
4f0b275
Merge branch 'main' into NOTIFY-846-silently-handle-push-notifications
Prithpal-Sooriya Jul 18, 2024
7f5130c
Merge branch 'main' into NOTIFY-846-silently-handle-push-notifications
Prithpal-Sooriya Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions ...-services-controller/src/NotificationServicesController/NotificationServicesController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,28 +284,40 @@ export default class NotificationServicesController extends BaseController<
if (!this.#isPushIntegrated) {
return;
}
await this.messagingSystem.call(
'NotificationServicesPushController:enablePushNotifications',
UUIDs,
);
try {
await this.messagingSystem.call(
'NotificationServicesPushController:enablePushNotifications',
UUIDs,
);
} catch (e) {
log.error('Silently failed to enable push notifications', e);
}
},
disablePushNotifications: async (UUIDs: string[]) => {
if (!this.#isPushIntegrated) {
return;
}
await this.messagingSystem.call(
'NotificationServicesPushController:disablePushNotifications',
UUIDs,
);
try {
await this.messagingSystem.call(
'NotificationServicesPushController:disablePushNotifications',
UUIDs,
);
} catch (e) {
log.error('Silently failed to disable push notifications', e);
}
},
updatePushNotifications: async (UUIDs: string[]) => {
if (!this.#isPushIntegrated) {
return;
}
await this.messagingSystem.call(
'NotificationServicesPushController:updateTriggerPushNotifications',
UUIDs,
);
try {
await this.messagingSystem.call(
'NotificationServicesPushController:updateTriggerPushNotifications',
UUIDs,
);
} catch (e) {
log.error('Silently failed to update push notifications', e);
}
},
subscribe: () => {
if (!this.#isPushIntegrated) {
Expand Down
Loading