Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PhishingDetector to export #4553

Merged
merged 11 commits into from
Sep 10, 2024
Merged

Conversation

409H
Copy link
Contributor

@409H 409H commented Jul 24, 2024

Explanation

Exports PhishingDetector so we can use it within tests for MetaMask/eth-phishing-detect and other third party repos can utilise it.

References

Changelog

@metamask/phishing-controller

  • exports PhishingDetector

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@409H 409H added the enhancement New feature or request label Jul 24, 2024
@409H 409H requested a review from a team as a code owner July 24, 2024 14:29
@409H 409H marked this pull request as draft July 24, 2024 18:08
@409H 409H marked this pull request as ready for review July 24, 2024 18:56
mcmire
mcmire previously approved these changes Jul 24, 2024
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I failed to notice that we hadn't done this before. I mistakenly thought that it was introduced in 10.1.0 and noted it in the changelog there. We will have to make another note in the next release.

@409H 409H requested a review from a team as a code owner August 29, 2024 14:11
@409H 409H merged commit 600060a into main Sep 10, 2024
116 checks passed
@409H 409H deleted the enhancement/export-phishing-detector branch September 10, 2024 02:19
@samczsun
Copy link

@metamaskbot publish-preview

(will this work?)

@Mrtenz
Copy link
Member

Mrtenz commented Sep 10, 2024

@samczsun This is now released in @metamask/phishing-controller@^12.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants