-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move composable-controller utility types to base-controller #4581
Merged
MajorLift
merged 6 commits into
main
from
move-ComposableController-utility-types-to-BaseController
Aug 21, 2024
Merged
Move composable-controller utility types to base-controller #4581
MajorLift
merged 6 commits into
main
from
move-ComposableController-utility-types-to-BaseController
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
240620-fix-ComposableController-validator-types
to
main
August 20, 2024 17:04
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
…roller to base-controller
… coverage to 100%
b5937ee
to
7a3baa8
Compare
mikesposito
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This commit moves
BaseController
-related types and functions in@metamask/composable-controller
to@metamask/base-controller
.Because applying these changes requires a concurrent major update of
@metamask/base-controller
, this commit will be excluded from@metamask/composable-controller@8.0.0
(#4467), so that complications can be avoided while applying8.0.0
to mobile.References
ComposableController
API updates that fix broken functionality metamask-mobile#10441Changelog
@metamask/base-controller
(minor)Added
@metamask/composable-controller@8.0.0
into@metamask/base-controller
: typesLegacyControllerStateConstraint
,RestrictedControllerMessengerConstraint
and type guard functionsisBaseController
,isBaseControllerV1
(#4581)ControllerInstance
,BaseControllerInstance
,StateDeriverConstraint
,StateMetadataConstraint
,StatePropertyMetadataConstraint
,BaseControllerV1Instance
,ConfigConstraintV1
,StateConstraintV1
(#4581)@metamask/composable-controller
(major)Removed
LegacyControllerStateConstraint
,RestrictedControllerMessengerConstraint
, and type guard functionsisBaseController
,isBaseControllerV1
(#4467)@metamask/base-controller@6.2.0
.Checklist