Bump typescript
from ~5.2.2
to ~5.4.5
#4586
Draft
+84
−82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Explanation
These two version upgrades are being batched together because the regressions introduced in v5.3 are resolved in v5.4 without any additional action needing to be taken.
Regressions
~5.3.3
WritableDraft
type: https://github.com/MetaMask/core/actions/runs/10210374669/job/28249938932?pr=4585~5.4.5
TS2589: Type instantiation is excessively deep and possibly infinite.
ts-expect-error
directives.Json
causes a recursive error in conjunction withDraft
/WritableDraft
types from Immer utils#168) are having flaky interactions.ts-jest
, nottypescript
.Changelog
Checklist