fix: profile-sync-controller - make fixture constants lazy #4592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a temp fix so that mobile does not compute these fixtures are runtime. we do need to support multiple exports to ensure that these are not called.
Prithpal-Sooriya
added
the
team-notifications
...ion-services-controller/src/NotificationServicesController/NotificationServicesController.ts
Show resolved
Hide resolved
Comment on lines
+7
to
+10
| // NOTE - using encryption.encryptString directly in fixtures causes issues on mobile. | ||
| // This is because this fixture is getting added in at run time. Will be improved once we support multiple exports | ||
| export const MOCK_ENCRYPTED_STORAGE_DATA = () => | ||
| encryption.encryptString(MOCK_STORAGE_DATA, MOCK_STORAGE_KEY); |
There was a problem hiding this comment.
As mentioned, mobile has an issue with running this fixture.
This most likely is because our relative imports (barrel files), drag in these fixtures and need to be computed once pulled in.
We will explore multiple file exports, this should mostly alleviate this issue.
E.g.
// If want to reuse fixtures, we can have a separate endpoint for this. Likewise for other areas for this controller.
import {} from '@metamask/profile-sync-controller/fixtures'
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Prithpal-Sooriya
deleted the
refactor/profile-sync-mobile-fixture-fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
this is a temp fix so that mobile does not compute these fixtures are runtime. we do need to support multiple exports to ensure that these are not called.
References
https://consensyssoftware.atlassian.net/browse/NOTIFY-958
Changelog
@metamask/profile-sync-controllerChecklist