Pull in networkCongestion along with gas estimates #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
pull-in-network-congestion
branch
from
161881e
to
2f30b71
Compare
mcmire
force-pushed
the
add-eth-fee-history-fallback-for-gas-estimates
branch
from
fa28639
to
6c94a80
Compare
mcmire
force-pushed
the
pull-in-network-congestion
branch
from
2f30b71
to
eeed078
Compare
mcmire
force-pushed
the
add-eth-fee-history-fallback-for-gas-estimates
branch
from
6c94a80
to
47e0fa0
Compare
mcmire
force-pushed
the
pull-in-network-congestion
branch
from
eeed078
to
1de85be
Compare
mcmire
force-pushed
the
add-eth-fee-history-fallback-for-gas-estimates
branch
2 times, most recently
from
fbbc906
to
46c3788
Compare
Base automatically changed from
add-eth-fee-history-fallback-for-gas-estimates
to
eip-1559-v2
December 2, 2021 16:57
The Metaswap API now includes a `networkCongestion` property when requesting EIP-1559-compatible gas fee estimates. This value, which is a number from 0 to 1, where 0 represents "not congested" and 1 represents "extremely congested", can be used to communicate the status of the network to users when they are sending transactions. This commit ensures that GasFeeController includes `networkCongestion` as part of the state it persists, no matter if using the Metaswap API to obtain this information or falling back to `eth_feeHistory`. This is a part of the EIP-1559 v2 work.
mcmire
force-pushed
the
pull-in-network-congestion
branch
from
1de85be
to
77b1410
Compare
mcmire
commented
Dec 6, 2021
| @@ -50,21 +82,22 @@ describe('fetchGasEstimatesViaEthFeeHistory', () => { | |||
| minWaitTimeEstimate: 15_000, | |||
| maxWaitTimeEstimate: 30_000, | |||
| suggestedMaxPriorityFeePerGas: '1', | |||
| suggestedMaxFeePerGas: '111', | |||
| suggestedMaxFeePerGas: '221', | |||
There was a problem hiding this comment.
I changed the base fee per gas values above so that's why these changed.
jpuri
approved these changes
Dec 7, 2021
mcmire
added a commit
that referenced
this pull request
Dec 10, 2021
The Metaswap API now includes a `networkCongestion` property when requesting EIP-1559-compatible gas fee estimates. This value, which is a number from 0 to 1, where 0 represents "not congested" and 1 represents "extremely congested", can be used to communicate the status of the network to users when they are sending transactions. This commit ensures that GasFeeController includes `networkCongestion` as part of the state it persists, no matter if using the Metaswap API to obtain this information or falling back to `eth_feeHistory`. This is a part of the EIP-1559 v2 work.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The Metaswap API now includes a `networkCongestion` property when requesting EIP-1559-compatible gas fee estimates. This value, which is a number from 0 to 1, where 0 represents "not congested" and 1 represents "extremely congested", can be used to communicate the status of the network to users when they are sending transactions. This commit ensures that GasFeeController includes `networkCongestion` as part of the state it persists, no matter if using the Metaswap API to obtain this information or falling back to `eth_feeHistory`. This is a part of the EIP-1559 v2 work.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The Metaswap API now includes a `networkCongestion` property when requesting EIP-1559-compatible gas fee estimates. This value, which is a number from 0 to 1, where 0 represents "not congested" and 1 represents "extremely congested", can be used to communicate the status of the network to users when they are sending transactions. This commit ensures that GasFeeController includes `networkCongestion` as part of the state it persists, no matter if using the Metaswap API to obtain this information or falling back to `eth_feeHistory`. This is a part of the EIP-1559 v2 work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Metaswap API now includes a
networkCongestionproperty whenrequesting EIP-1559-compatible gas fee estimates. This value, which is a
number from 0 to 1, where 0 represents "not congested" and 1 represents
"extremely congested", can be used to communicate the status of the
network to users when they are sending transactions.
This commit ensures that GasFeeController includes
networkCongestionas part of the state it persists, no matter if using the Metaswap API to
obtain this information or falling back to
eth_feeHistory.This is a part of the EIP-1559 v2 work.