Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

5.0.0 #74

Merged
merged 6 commits into from
Dec 13, 2022
Merged

5.0.0 #74

merged 6 commits into from
Dec 13, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 8, 2022

This is the release candidate for version 5.0.0.

[5.0.0]

Changed

  • BREAKING: Update minimum Node.js version from v12 to v14 (#67)
  • BREAKING: Makes version-specific signTypedData methods private (#70)
    • Consumers should use the generic signTypedData method and pass the version they'd like as a property in the options argument.
  • BREAKING: Makes the wallets property private (#70)
    • Consumers should not use this property as it is intended for internal use only.
  • BREAKING: Makes getPrivateKeyFor a private method (#70)
    • Consumers who wish to get the private key for a given account should use the exportAccount method.

Removed

  • BREAKING: Remove redundant newGethSignMessage method (#70)
    • Consumers can use signPersonalMessage method as a replacement for newGethSignMessage.
  • BREAKING: HDKeyring no longer extends EventEmitter, so no EventEmitter methods are available on this class (#70)

@adonesky1 adonesky1 marked this pull request as ready for review December 12, 2022 17:46
@adonesky1 adonesky1 requested a review from a team as a code owner December 12, 2022 17:46
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Gudahtt
Copy link
Member

Gudahtt commented Dec 12, 2022

There are two changes from #70 that seem notable enough to be mentioned: updating to eth-sig-util to v5 and adding @ethereumjs/util@^8.0.2 as a dependency. Both of those changes mean that you must support ES2020 to use this package, because @ethereumjs/util@8 uses an ES2020 build target (and it's used indirectly via eth-sig-util as well).

@Gudahtt
Copy link
Member

Gudahtt commented Dec 12, 2022

I'd list #69 as a change as well.

@adonesky1
Copy link
Contributor

@Gudahtt I've added additional entries for both #69 and #70 here:
a5f42d1

github-actions and others added 5 commits December 13, 2022 11:24
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 merged commit 5f9e4c3 into main Dec 13, 2022
@adonesky1 adonesky1 deleted the release/5.0.0 branch December 13, 2022 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants