This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
release/5.0.0
branch
from
December 12, 2022 17:46
3726785
to
5f525c8
Compare
Gudahtt
reviewed
Dec 12, 2022
There are two changes from #70 that seem notable enough to be mentioned: updating to |
I'd list #69 as a change as well. |
adonesky1
force-pushed
the
release/5.0.0
branch
from
December 13, 2022 16:51
76dcff1
to
1f70ac4
Compare
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
adonesky1
force-pushed
the
release/5.0.0
branch
from
December 13, 2022 17:34
a5f42d1
to
0da4260
Compare
Gudahtt
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 5.0.0.
[5.0.0]
Changed
signTypedData
methods private (#70)signTypedData
method and pass the version they'd like as a property in the options argument.wallets
property private (#70)getPrivateKeyFor
a private method (#70)exportAccount
method.Removed
newGethSignMessage
method (#70)signPersonalMessage
method as a replacement for newGethSignMessage.HDKeyring
no longer extendsEventEmitter
, so noEventEmitter
methods are available on this class (#70)