don't pass the block number to eth_estimateGas #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two different issues found:
Currently the blockTagIndex for eth_estimateGas 0, but that's not correct since the index 0 is the tx itself. That throws an exception here slice is not a function since it's an object (the TX)
(Can be reproduced here
After fixing the index I'm sending the right data to infura but still getting an RPC response error saying
too many arguments, want at most 1Because of this, I assume we don't have to pass the block number at all to the eth_estimageGas call.
With this PR both problems are fixed