-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump ethereum-cryptography, @ethereumjs/util #302
Conversation
46b8579
to
50964f8
Compare
@legobeat Are there any consequences for bumping these packages? Is this just to make sure we're up to date, or is there an issue that this fixes? |
@mcmire intention with prefixing it as |
|
50964f8
to
0a8ffff
Compare
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview: 🚮 Removed packages: ethereum-cryptography@1.2.0 |
changed this PR to an smaller upgrade to For updates on getting in line with upstream and further context: |
0a8ffff
to
bcfca18
Compare
Good call @Mrtenz. While we're on the subject, this looks to be the comparison between ethereum-cryptography 1.1.2 and 1.2.0: ethereum/js-ethereum-cryptography@c434a5f...0cf402c (no tags for these releases, unfortunately, and no changelog either). I'm not spotting anything that could cause any issues, but I'm also not an subject matter expert on this. |
@mcmire @legobeat I think we should just hold off for a second on this PR and bump to the versions released here: ethereumjs/ethereumjs-monorepo#2648 I have an open PR here that will most likely be included to fix any incompatibilities with the extension: ethereumjs/ethereumjs-monorepo#2656 Then we should probably also bump |
Release notes: https://github.com/ethereum/js-ethereum-cryptography/releases/tag/1.2.0 - AES bugfixes - bump dependencies
50b6f84
to
7f5aca6
Compare
7f5aca6
to
0cc5d33
Compare
|
The way I understand this is that yes, it's still pulled in, but WASM parts are now dead code depending on platform. rf https://github.com/MetaMask/utils/pull/100/files |
It is available, but needs to be enabled to be used. By default it will use |
No description provided.