Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out ethereumjs-abi for @metamask/abi-utils #319

Merged
merged 12 commits into from
Sep 9, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jul 7, 2023

This is a rebased version of #273 with lint issues addressed.

This removes the inlined ethereumjs-abi package in favour of @metamask/abi-utils. That also means that we can get rid of the BN.js dependency.

@legobeat legobeat requested a review from Mrtenz July 7, 2023 03:55
@socket-security
Copy link

socket-security bot commented Jul 7, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@socket-security
Copy link

socket-security bot commented Jul 7, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Mrtenz
Mrtenz previously approved these changes Aug 22, 2023
@legobeat legobeat marked this pull request as ready for review August 30, 2023 06:33
@legobeat legobeat requested review from Mrtenz and a team August 30, 2023 06:33
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Aug 30, 2023
@legobeat legobeat requested a review from kumavis August 30, 2023 06:34
@legobeat legobeat requested review from a team and removed request for a team September 9, 2023 07:30
@legobeat legobeat merged commit c740e8d into MetaMask:main Sep 9, 2023
19 checks passed
@legobeat
Copy link
Contributor Author

legobeat commented Sep 9, 2023

Release proposal: #331

legobeat added a commit to legobeat/eth-sig-util that referenced this pull request Nov 19, 2023
the snapshot matches pre-v6 behavior, which was changed in MetaMask#319.
legobeat added a commit to legobeat/eth-sig-util that referenced this pull request Nov 20, 2023
the snapshot matches pre-v6 behavior, which was changed in MetaMask#319.
legobeat added a commit to legobeat/eth-sig-util that referenced this pull request Nov 20, 2023
the snapshot matches pre-v6 behavior, which was changed in MetaMask#319.
legobeat added a commit to legobeat/eth-sig-util that referenced this pull request Nov 20, 2023
the snapshot matches pre-v6 behavior, which was changed in MetaMask#319.
legobeat added a commit that referenced this pull request Nov 20, 2023
* test: add test for encoding 0x,0x0 as bytes
  the snapshot is based on v5.1.0. Behavior was changed in #319.
* fix: interpret `0x` as hex in bytes encodeField
legobeat added a commit to legobeat/eth-sig-util that referenced this pull request Nov 21, 2023
the snapshot matches pre-v6 behavior, which was changed in MetaMask#319.
legobeat added a commit that referenced this pull request Nov 21, 2023
* test: add test for encoding 0x,0x0 as bytes
    the snapshot matches v5.1.0 behavior, which was changed in #319.
* fix: interpret `0x` as hex in bytes encodeField
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants