This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
fix: ignore event if account was already removed #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an account is removed using MetaMask's UI, we remove the account from the keyring, and then we call the snap to delete the account. It's done this way to ensure that the account is always removed from MetaMask, even if the snap fails.
As a consequence, when the snap notifies the keyring that it has removed the account, the account no longer in the keyring, which throws an error.
This PR changes this behavior and ignores the
AccountDeletedevent in case the account doesn't exist in the keyring.Fixes: MetaMask/accounts-planning#58