This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
fix: remove the removeAccountsBySnapId method
#121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danroc
changed the title
removeAccountsBySnapIdremoveAccountsBySnapId method
danroc
force-pushed
the
feature/remove-remove-account-snap
branch
from
7793ca0 to
1debe04
Compare
Accounts shouldn't be removed by directly calling the keyring because they also need to be removed from other controllers, which is done by the `removeAccount` method from `metamask-controller.js`.
danroc
force-pushed
the
feature/remove-remove-account-snap
branch
from
1debe04 to
871d975
Compare
montelaidev
approved these changes
Sep 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accounts shouldn't be removed by directly calling the keyring because they also need to be removed from other controllers, which is done by the
removeAccountmethod frommetamask-controller.js.