This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
feat!: add KeyringExecutionContext to user ops methods #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
added
team-accounts
ccharly
changed the title
ccharly
force-pushed
the
feature/307/caip-2-user-ops
branch
6 times, most recently
from
7f43cda
to
31a9ef9
Compare
ccharly
force-pushed
the
feature/307/caip-2-user-ops
branch
from
ced56af
to
b92c51f
Compare
ccharly
changed the title
ccharly
force-pushed
the
feature/307/caip-2-user-ops
branch
from
b92c51f
to
5af018d
Compare
danroc
reviewed
Mar 15, 2024
danroc
reviewed
Mar 15, 2024
danroc
reviewed
Mar 15, 2024
ccharly
force-pushed
the
feature/307/caip-2-user-ops
branch
3 times, most recently
from
63080ef
to
e4de14a
Compare
ccharly
force-pushed
the
feature/307/caip-2-user-ops
branch
from
e4de14a
to
c57c685
Compare
danroc
approved these changes
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Description
Adding an additional parameter about the "execution context" (contains only
chainIdfor now) for User operations methods. This will also help computing the CAIP-2 scope/chain-id for underlying calls later on.Related to