This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: handle accountNameSuggestion
and displayConfirmation
options in #handleAccountCreated
#300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danroc
reviewed
May 24, 2024
danroc
reviewed
May 24, 2024
danroc
reviewed
May 24, 2024
# Conflicts: # src/SnapKeyring.test.ts
ccharly
reviewed
May 28, 2024
ccharly
approved these changes
May 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
accountNameSuggestion
anddisplayConfirmation
in the AccountCreatedEventStruct#handleAccountCreated
now parses these new options from the message params and passes them along with other properties to the add account callbackDependent on PR 301