This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
feat: add getAccountBalances method to Keyring
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danroc
force-pushed
the
feature/add-get-balances
branch
3 times, most recently
from
6966f74 to
4ec30c8
Compare
danroc
force-pushed
the
feature/add-get-balances
branch
from
4ec30c8 to
59a1187
Compare
danroc
force-pushed
the
feature/add-get-balances
branch
2 times, most recently
from
c72985f to
c457fa3
Compare
danroc
force-pushed
the
feature/add-get-balances
branch
2 times, most recently
from
94e72b8 to
e0d1be8
Compare
ccharly
reviewed
May 28, 2024
danroc
force-pushed
the
feature/add-get-balances
branch
3 times, most recently
from
fba55aa to
64b0e0f
Compare
danroc
force-pushed
the
feature/add-get-balances
branch
from
64b0e0f to
b6882da
Compare
ccharly
reviewed
May 29, 2024
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
ccharly
reviewed
May 29, 2024
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
ccharly
approved these changes
May 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the method that will be used to get the balances of a given account.
Fixes: https://github.com/MetaMask/accounts-planning/issues/457