Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: session manager tests #122

Merged
merged 3 commits into from
Jul 10, 2024
Merged

chore: session manager tests #122

merged 3 commits into from
Jul 10, 2024

Conversation

elefantel
Copy link
Contributor

In this PR:
• SessionManager unit tests
• Abstracting logging and injecting logger as dependency on all classes using it

@elefantel elefantel self-assigned this Jul 9, 2024
@elefantel elefantel requested a review from a team as a code owner July 9, 2024 15:29
andreahaku
andreahaku previously approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andreahaku
andreahaku approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elefantel elefantel merged commit 2a2dc5e into main Jul 10, 2024
2 checks passed
@elefantel elefantel deleted the session-manager-tests branch July 17, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees

@elefantel elefantel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elefantel @andreahaku