Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Wallet API" terminology #1125

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Add "Wallet API" terminology #1125

merged 4 commits into from
Feb 7, 2024

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Feb 6, 2024

Add "Wallet API" terminology. Fixes #1120.

This PR is conjunction with MetaMask/api-specs#185, which updates the JSON-RPC reference index page to mention the Wallet API.

Preview: https://docs.metamask.io/1120-wallet-api/

@alexandratran alexandratran marked this pull request as ready for review February 6, 2024 19:45
@alexandratran alexandratran requested review from a team as code owners February 6, 2024 19:45
Copy link

github-actions bot commented Feb 6, 2024

Preview published: 1120-wallet-api

1 similar comment
Copy link

github-actions bot commented Feb 6, 2024

Preview published: 1120-wallet-api

@vandan
Copy link
Contributor

vandan commented Feb 6, 2024

This page should match the tags we describe on the new index page's description (api-specs change): https://docs.metamask.io/1120-wallet-api/wallet/concepts/wallet-api/

@alexandratran
Copy link
Contributor Author

@vandan Thanks for catching, I just removed it in the concepts page, in favor of the list on the new index page.

Copy link

github-actions bot commented Feb 6, 2024

Preview published: 1120-wallet-api

Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@vandan vandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the updates. Looks nice and consistent now.

@alexandratran alexandratran merged commit c06b5c7 into main Feb 7, 2024
6 checks passed
@alexandratran alexandratran deleted the 1120-wallet-api branch February 7, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Wallet API" terminology
3 participants