Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Snaps static file API #1138

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Document the Snaps static file API #1138

merged 5 commits into from
Feb 15, 2024

Conversation

ziad-saab
Copy link
Contributor

Fixes MetaMask/metamask-planning#1491

@ziad-saab ziad-saab requested review from a team as code owners February 14, 2024 19:04
@ziad-saab ziad-saab marked this pull request as draft February 14, 2024 19:04
@ziad-saab ziad-saab marked this pull request as ready for review February 14, 2024 19:06
Copy link

Preview published: zs/snap-getfile

Copy link

Preview published: zs/snap-getfile

Copy link
Collaborator

@Montoya Montoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording

snaps/index.mdx Outdated Show resolved Hide resolved
snaps/how-to/handle-static-files.md Outdated Show resolved Hide resolved
@Montoya
Copy link
Collaborator

Montoya commented Feb 14, 2024

Preview published: zs/snap-getfile

I don't know why the icon does not show up in this build

@ziad-saab
Copy link
Contributor Author

Preview published: zs/snap-getfile

I don't know why the icon does not show up in this build

It definitely shows up for me. It's a base64 URL.

Copy link

Preview published: zs/snap-getfile

@alexandratran alexandratran self-assigned this Feb 14, 2024
Copy link

Preview published: zs/snap-getfile

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this into the new "features" category and made some edits to related content. LGTM.

Copy link

Preview published: zs/snap-getfile

@ziad-saab ziad-saab merged commit 5ed0f01 into main Feb 15, 2024
6 checks passed
@ziad-saab ziad-saab deleted the zs/snap-getfile branch February 15, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants