Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snaps transaction-insights missing dependencies #1175

Closed

Conversation

marvinmarnold
Copy link

Missing @metamask/snaps-types and @metamask/snaps-ui which are referenced later in index.ts.

Missing @metamask/snaps-types and @metamask/snaps-ui which are referenced later in index.ts.
@marvinmarnold marvinmarnold requested review from a team as code owners February 26, 2024 17:57
@joaniefromtheblock joaniefromtheblock self-assigned this Mar 1, 2024
@joaniefromtheblock
Copy link
Contributor

Thank you for this helpful PR @marvinmarnold and for catching this. We'll update the docs accordingly.

@Montoya
Copy link
Collaborator

Montoya commented Mar 6, 2024

When using the latest template, the dependency is @metamask/snaps-sdk. The mentioned packages are deprecated in favor of this package. Please test the flow and see if it works with the latest template before making this change.

Copy link
Collaborator

@Montoya Montoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment

@Montoya
Copy link
Collaborator

Montoya commented Mar 11, 2024

Closing in favor of #1206

@Montoya Montoya closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants