Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Snaps CLI documentation #1178

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Update Snaps CLI documentation #1178

merged 7 commits into from
Mar 5, 2024

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Feb 28, 2024 •
edited
Loading

This updates the Snaps CLI documentation (subcommands, subcommand options, and new Webpack configuration options). Fixes #1169.

Previews:

@github-actions GitHub Actions
Copy link

Preview published: 1169-update-snaps-cli

@alexandratran alexandratran marked this pull request as ready for review February 29, 2024 06:56
@alexandratran alexandratran requested review from a team as code owners February 29, 2024 06:56
@github-actions GitHub Actions
Copy link

Preview published: 1169-update-snaps-cli

@github-actions GitHub Actions
Copy link

Preview published: 1169-update-snaps-cli

Mrtenz
Mrtenz requested changes Mar 1, 2024
View reviewed changes
snaps/learn/about-snaps/files.md Outdated Show resolved Hide resolved
snaps/reference/cli/options.md Outdated Show resolved Hide resolved
@Montoya @Mrtenz
Update snaps/reference/cli/options.md
6290df1 
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Preview published: 1169-update-snaps-cli

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Preview published: 1169-update-snaps-cli

joaniefromtheblock
joaniefromtheblock approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think some of our changes overlap per this PR, but will pull yours in.

bgravenorst
bgravenorst approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

snaps/learn/about-snaps/files.md Outdated Show resolved Hide resolved
snaps/reference/cli/subcommands.md Show resolved Hide resolved
snaps/reference/cli/subcommands.md Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Preview published: 1169-update-snaps-cli

@alexandratran alexandratran requested a review from a team as a code owner March 5, 2024 23:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Preview published: 1169-update-snaps-cli

@alexandratran alexandratran merged commit 8b013b5 into main Mar 5, 2024
8 checks passed
@alexandratran alexandratran deleted the 1169-update-snaps-cli branch March 5, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

@bgravenorst bgravenorst bgravenorst approved these changes

@joaniefromtheblock joaniefromtheblock joaniefromtheblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Snaps CLI documentation
5 participants
@alexandratran @Mrtenz @bgravenorst @joaniefromtheblock @Montoya