Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated instances with metamask/snaps-sdk #1210

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Conversation

joaniefromtheblock
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock commented Mar 12, 2024

Closes #1211

I believe the following are deprecated:

  • metamask/snaps-types
  • metamask/snaps-ui

We should remove instances and replaces with metamask/snaps-sdk

@Montoya

@joaniefromtheblock joaniefromtheblock requested review from a team as code owners March 12, 2024 15:07
Copy link

Preview published: remove-deprecated

Copy link

Preview published: remove-deprecated

snaps/reference/entry-points.md Outdated Show resolved Hide resolved
snaps/reference/entry-points.md Outdated Show resolved Hide resolved
snaps/reference/entry-points.md Outdated Show resolved Hide resolved
snaps/reference/entry-points.md Outdated Show resolved Hide resolved
Copy link

Preview published: remove-deprecated

Copy link

Preview published: remove-deprecated

@alexandratran
Copy link
Contributor

@joaniefromtheblock Do you mind addressing these two comments in this PR? #1206 (review)

@joaniefromtheblock
Copy link
Contributor Author

Yes @alexandratran. Will add to this PR ;)

Copy link

Preview published: remove-deprecated

Copy link

Preview published: remove-deprecated

@joaniefromtheblock joaniefromtheblock self-assigned this Mar 13, 2024
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Montoya Montoya merged commit eb7af90 into main Mar 13, 2024
8 checks passed
@Montoya Montoya deleted the remove-deprecated branch March 13, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deprecated packages
3 participants