Restructure and improve docs to highlight connecting via EIP-6963 #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview published: 1197-improve-eip-6963 |
|
Preview published: 1197-improve-eip-6963 |
Montoya
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Massive improvement. We should consider addressing https://docs.metamask.io/wallet/concepts/convenience-libraries/ in a separate ticket, but this is great for now.
Montoya
approved these changes
Mar 15, 2024
|
Preview published: 1197-improve-eip-6963 |
bgravenorst
approved these changes
Mar 18, 2024
|
Preview published: 1197-improve-eip-6963 |
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1197. Updates include:
providerinstead ofwindow.ethereum. All instances include an in-line comment mentioning to usewindow.ethereumif you don't support EIP-6963. For example: https://docs.metamask.io/1197-improve-eip-6963/wallet/how-to/manage-networks/detect-network/To do (for future PRs):