-
-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document using node.js modules in Snaps #1238
Conversation
Preview published: 855-nodejs-modules |
Preview published: 855-nodejs-modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a polyfills
option in the config which doesn't require changing the Webpack config. Looks like we forgot to add this to the CLI's README 😅
Preview published: 855-nodejs-modules |
1 similar comment
Preview published: 855-nodejs-modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR slightly rearranges the "Snaps execution environment" concept page and adds a note on how to use the Node.js built-in modules, which are not supported by default. It also documents the missing
polyfills
config option. Fixes #855.Preview: https://docs.metamask.io/855-nodejs-modules/snaps/learn/about-snaps/execution-environment/