Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Connect to MetaMask with EIP-6963 TypeScript & React examples #1247

Merged
merged 24 commits into from
Apr 10, 2024
Merged

Update Connect to MetaMask with EIP-6963 TypeScript & React examples #1247

merged 24 commits into from
Apr 10, 2024

Conversation

httpJunkie
Copy link
Contributor

@httpJunkie httpJunkie commented Apr 8, 2024 •
edited by alexandratran
Loading

Description

I am updating the Connect to MetaMask docs page to simplify the React example and add a Vanilla TypeScript example *per @Montoya

Issue(s) fixed

This updates the page to show best practices for implementing EIP-6963 and connecting to Metamask

Fixes #1215

Preview

https://docs.metamask.io/connect-detect-metamask/wallet/how-to/connect/

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.
  • The proposed changes have been reviewed and approved by someone from the MetaMask team.

@httpJunkie httpJunkie requested review from a team as code owners April 8, 2024 23:06
@httpJunkie httpJunkie requested a review from vandan April 8, 2024 23:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

Preview published: connect-detect-metamask

@httpJunkie
Update more of the Vanilla TypeScript example:
2ad7e76 
*With better explanations and comments removes where not needed
@httpJunkie
add npm and bash commands
e2cce4a
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

Preview published: connect-detect-metamask

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

Preview published: connect-detect-metamask

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Preview published: connect-detect-metamask

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Preview published: connect-detect-metamask

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Preview published: connect-detect-metamask

@httpJunkie httpJunkie requested a review from Montoya April 9, 2024 06:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Preview published: connect-detect-metamask

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Preview published: connect-detect-metamask

vandan
vandan approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@vandan vandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted some re-wording suggestions.
other than those, LGTM.

@github-actions GitHub Actions
Copy link

Preview published: connect-detect-metamask

@github-actions GitHub Actions
Copy link

Preview published: connect-detect-metamask

@httpJunkie
Copy link
Contributor Author

I see that we decided to go back to the step by step version rather than having the tabs. I had tried the tabs approach considering Christian's comments and I thought that it would be easier to view the two approaches side-by-side. But I don't have a strong opinion either way.

@httpJunkie
Copy link
Contributor Author

I think we are good to go, we may want to reference the types that need to be added in the React steps. But otherwise, this looks good.

@github-actions GitHub Actions
Copy link

Preview published: connect-detect-metamask

@github-actions GitHub Actions
Copy link

Preview published: connect-detect-metamask

@Montoya @joaniefromtheblock
vanilla should be lowercase
2c1ab6e 
Co-authored-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

Preview published: connect-detect-metamask

joaniefromtheblock
joaniefromtheblock approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexandratran
Copy link
Contributor

Addressed final suggestions and made edits to simplify and shorten the intro to the Connect page. The goal is to provide the essential introductory info in a readable way, while getting to the instructions ASAP.

@github-actions GitHub Actions
Copy link

Preview published: connect-detect-metamask

1 similar comment
@github-actions GitHub Actions
Copy link

Preview published: connect-detect-metamask

@alexandratran alexandratran merged commit f4ea3de into main Apr 10, 2024
8 checks passed
@alexandratran alexandratran deleted the connect-detect-metamask branch April 10, 2024 20:40
@Montoya
Copy link
Collaborator

Montoya commented Apr 10, 2024

Massive improvement! Great job everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandratran alexandratran alexandratran approved these changes

@Montoya Montoya Montoya approved these changes

@vandan vandan vandan approved these changes

@joaniefromtheblock joaniefromtheblock joaniefromtheblock approved these changes

Assignees

@alexandratran alexandratran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add EIP-6963 code samples for vanilla JS and TS
5 participants
@httpJunkie @alexandratran @Montoya @vandan @joaniefromtheblock