Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Snaps parameters in dapp API section #1380

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

FrederikBolding
Copy link
Member

Description

Fixes the parameters in the examples section of "Wallet API for Snaps". The documentation explaining the format was correct, but the code example was not.

wallet_requestSnaps, wallet_snap & wallet_invokeSnap all take object parameters only.

@FrederikBolding FrederikBolding requested review from a team as code owners July 3, 2024 11:49
Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 11:49am

Copy link
Contributor

@m4sterbunny m4sterbunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrederikBolding FrederikBolding merged commit 94ad9a2 into main Jul 3, 2024
6 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-wallet-api-snaps-docs branch July 3, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants